Closed Bug 1385211 Opened 8 years ago Closed 7 years ago

[css-writing-modes] date and time inputs are way too wide in vertical writing modes

Categories

(Core :: Layout: Form Controls, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?
firefox60 --- fixed

People

(Reporter: huijing, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: html5, testcase)

Attachments

(3 files)

Attached file testcase
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20170726100322 Steps to reproduce: Use the date input and time input elements in a HTML form on a page with writing-mode: vertical-rl applied. Actual results: The width of the date input and time input get set to 17895700, affecting the rendering of other elements on the page. Expected results: The width of the date input should be clamped at a reasonable width of the height/width of a single line of text.
Attached image input-date.jpg
Component: Untriaged → Layout: Form Controls
Product: Firefox → Core
" The size attribute gives the number of characters that, in a visual rendering, the user agent is to allow the user to see while editing the element's value. (...) The size IDL attribute (...) has a default value of 20. " HTML 5, section 4.10.5.3.2 The size attribute https://html.spec.whatwg.org/multipage/input.html#the-size-attribute " date (...) A date (year, month, day) with no time zone (...) time (...) A time (hour, minute, seconds, fractional seconds) with no time zone (...) " HTML 5, section 4.10.5 The input element https://html.spec.whatwg.org/multipage/input.html#the-input-element A size of 20 characters should suffice to type in a date (eg 2017-08-02 requires 10 characters; Wed, 02 Aug 2017 requires 16 characters) or a time (eg 20:41:28 requires 8 characters).
Blocks: writing-mode
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: html5, testcase
OS: Unspecified → All
Hardware: Unspecified → All
Summary: [css-writing-modes] date and time input not rendering correctly with vertical writing-mode → [css-writing-modes] date and time inputs with default size are way too tall in vertical writing modes
Version: 56 Branch → Trunk
We may need more tests for this bug report, along with screenshots of actual results. Also, it appears that HTML5 date and time inputs have just been recently implemented in Firefox: see bug 1366188 .
" The following content attributes must not be specified and do not apply to the element: (...) size " https://html.spec.whatwg.org/multipage/input.html#date-state-(type=date) https://html.spec.whatwg.org/multipage/input.html#time-state-(type=time) so the inherent size should be formatted and considerably smaller than 20 characters.
Chen Hui Jing, I just tried attachment 8891254 [details] with today nightly build (Firefox 57.0a1 buildID=20170804100354 under Linux) and the inputs are indeed way too wide, not too tall; so, I'm modifying summary accordingly. OTOH, an type="text" input without a specified size attribute, with default size, will be too tall. I'll create a bug report for that.
Summary: [css-writing-modes] date and time inputs with default size are way too tall in vertical writing modes → [css-writing-modes] date and time inputs are way too wide in vertical writing modes
Gérard, The reason I used “wide” was because the CSS property that controlled the input's size was width not height. The specification does state the “Layout rules that refer to the width use the height instead, and vice versa.”
I initially was confused because I could not get your actual results with a test I created ... but I later could get your actual results with a more recent nightly build and with your test. - - - - - - - When I try http://www.gtalbot.org/BugzillaSection/input-date-time-in-2-blocks-vrl.html then none of the inputs are displayed. I will create a bug report on that. - - - - - - - > an type="text" input without a specified size attribute, with default > size, will be too tall. I'll create a bug report for that. Bug 1387690
In Firefox 54 http://www.gtalbot.org/BugzillaSection/input-date-time-in-2-blocks-vrl.html will display 2 text inputs and not 1 date input and not 1 time input; and the 2 text inputs will be very tall. In Firefox 57.0a1 buildID=20170804100354 http://www.gtalbot.org/BugzillaSection/input-date-time-in-2-blocks-vrl.html the time input and the date input are not displayed.
> http://www.gtalbot.org/BugzillaSection/input-date-time-in-2-blocks-vrl.html > > then none of the inputs are displayed. I will create a bug report on that. Bug 1387758
Priority: -- → P3
Attached image rendering in firefox 60
This is not happening anymore in Firefox Nightly 60.0a1 (2018-02-20) (64-bit) It would be good to find what fixed it.
Maybe Bug 1267462 fixed it.
Extremely likely. IIRC we use display:flex inside of these inputs, and bug 1267462 fixed a pile of issues with flex & writing-modes.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1267462
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: